Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39133 )
Change subject: mb/kontron/mal10: Add COMe-mAL10 minimal support ......................................................................
Patch Set 20:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39133/20/src/mainboard/kontron/mal1... File src/mainboard/kontron/mal10/Kconfig:
https://review.coreboot.org/c/coreboot/+/39133/20/src/mainboard/kontron/mal1... PS20, Line 5: select USE_BLOBS : select ADD_FSP_BINARIES : select FSP_USE_REPO Remove
https://review.coreboot.org/c/coreboot/+/39133/20/src/mainboard/kontron/mal1... PS20, Line 23: config MAINBOARD_VENDOR : string : default "kontron" Remove, it is set by mb/kontron/Kconfig
https://review.coreboot.org/c/coreboot/+/39133/20/src/mainboard/kontron/mal1... File src/mainboard/kontron/mal10/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39133/20/src/mainboard/kontron/mal1... PS20, Line 2: romstage-y += romstage.c AFAIK not needed
https://review.coreboot.org/c/coreboot/+/39133/20/src/mainboard/kontron/mal1... File src/mainboard/kontron/mal10/cmos.layout:
https://review.coreboot.org/c/coreboot/+/39133/20/src/mainboard/kontron/mal1... PS20, Line 109: 5 0 Disable : 5 1 Enable Change to ID 2
https://review.coreboot.org/c/coreboot/+/39133/20/src/mainboard/kontron/mal1... File src/mainboard/kontron/mal10/romstage.c:
https://review.coreboot.org/c/coreboot/+/39133/20/src/mainboard/kontron/mal1... PS20, Line 4: #include <string.h> : #include <soc/romstage.h> : #include <soc/gpio_apl.h> : #include <soc/meminit.h> : #include <fsp/api.h> : #include <FspmUpd.h> : #include <console/console.h> : #include <gpio.h> : #include <spd_bin.h> : #include <soc/gpio.h> : #include <intelblocks/lpc_lib.h> : #include "gpio.h" Are all these needed? string.h and console/console.h seem to be unused.