Attention is currently required from: Erik van den Bogaert, Michał Żygowski, Frans Hendriks, Tristan Corrick, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro, Angel Pons, Piotr Król, Wim Vervoorn.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59880 )
Change subject: IASL: Ignore IASL's "Missing dependency" warning
......................................................................
Patch Set 7:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59880/comment/dca2b5fe_3c8f8c6b
PS1, Line 16:
so step back to patch set 5 ?
Ack
Patchset:
PS7:
This looks good to me. I verified that we get the warning at the end of the build: […]
Thank you.
Jenkins is checking if https://review.coreboot.org/c/coreboot/+/59174/ will build or if there is new boards to add to current patch
PS7:
Thank you.
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/59880/comment/1bfae14f_b63b050a
PS1, Line 278: CONFIG_BOARD_ACER_G43T_AM3
Instead of doing it this way, maybe add a IGNORE_IASL_MISSING_DEPENDENCY to each of the boards' kcon […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59880
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28b437194f08232727623009372327fec15215dd
Gerrit-Change-Number: 59880
Gerrit-PatchSet: 7
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Attention: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Comment-Date: Thu, 27 Jan 2022 18:36:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment