Attention is currently required from: Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52712 )
Change subject: drivers/intel/usb4: Dummy ......................................................................
Patch Set 1:
(5 comments)
File src/drivers/intel/usb4/retimer/retimer.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117905): https://review.coreboot.org/c/coreboot/+/52712/comment/654d29ca_5b73dc34 PS1, Line 69: * Return: -1 if timeout error occuring 'occuring' may be misspelled - perhaps 'occurring'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117905): https://review.coreboot.org/c/coreboot/+/52712/comment/c804da4b_0d827914 PS1, Line 243: * // Disable retimer online state please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117905): https://review.coreboot.org/c/coreboot/+/52712/comment/5af964ee_c2b8b88d PS1, Line 312: usb4_retimer_cb_get_power_state, /* Function 1 */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117905): https://review.coreboot.org/c/coreboot/+/52712/comment/dffbaf5f_b8a54d52 PS1, Line 313: usb4_retimer_cb_set_power_state, /* Function 2 */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117905): https://review.coreboot.org/c/coreboot/+/52712/comment/bef516de_7bf89f72 PS1, Line 355: for(port = 0; port < config->dfp_num; port++) { space required before the open parenthesis '('