Change in ...coreboot[master]: vendorcode/intel/fsp/fsp2_0/cml: Add FSP header files for Cometlake
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31529 )
Change subject: vendorcode/intel/fsp/fsp2_0/cml: Add FSP header files for Cometlake ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31529/3/src/vendorcode/intel/fsp/fsp2_0/come... File src/vendorcode/intel/fsp/fsp2_0/cometlake/FspUpd.h:
https://review.coreboot.org/#/c/31529/3/src/vendorcode/intel/fsp/fsp2_0/come... PS3, Line 3: Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
Were the contents of this file newly created, though? […]
do you mean that the copyright notice above applies to FSP as a whole and not just this file?
Yes, its not only applied to this files, it applies to entire FSP code
https://review.coreboot.org/#/c/31529/3/src/vendorcode/intel/fsp/fsp2_0/come... PS3, Line 40: #define FSPT_UPD_SIGNATURE 0x545F4450554C4643 /* 'CFLUPD_T' */
Nothing to worry beside confusion, making bisecting even harder than […]
Hopefully next RC release will fix this problem.
-
Subrata Banik (Code Review)