Attention is currently required from: Jason Glenesk, Marshall Dawson, Rob Barnes, Felix Held.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59017 )
Change subject: soc/amd/psp_verstage: Get vb2_context early
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/59017/comment/03c69e38_10d32ff1
PS1, Line 224:
Turns out, vbnv_init(ctx->nvdata) fails here because the cmos isn't ready until after verstage_soc_e […]
If map_fch_devices completely fails I don't think there's anything to do with our recovery process, similar to hardware failure cases. If i2c mapping has been failed vboot won't be able to communicate with the TPM.
Since we have very little control over how the PSP works and this is unlikely to fail, I think one option would be to use assert() here rather than vboot recovery.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59017
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7267a14ab048781b8998d3a6f4220de10e7df250
Gerrit-Change-Number: 59017
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 10 Nov 2021 09:56:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won
khwon@chromium.org
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment