Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42902 )
Change subject: mb/google/volteer: set tcc_offset value to 10 ......................................................................
mb/google/volteer: set tcc_offset value to 10
Set tcc_offset value to 10 in devicetree for Thermal Control Circuit (TCC) activation feature.
BUG=None BRANCH=None TEST=Built for volteer platform and verified the MSR value
Change-Id: I6438547e09a3ff3a1c01addfcc01383e89f5b435 Signed-off-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/42902/1
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 0c581a5..300fb7e 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -222,6 +222,8 @@
register "Device4Enable" = "1"
+ register "tcc_offset" = "10" # TCC of 90 + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value |
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42902 )
Change subject: mb/google/volteer: set tcc_offset value to 10 ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42902 )
Change subject: mb/google/volteer: set tcc_offset value to 10 ......................................................................
Patch Set 1: Code-Review+2
this is a spin-off of its parent commit (which got merged), plus it's a mainboard specific change, so I'm not waiting the 24hs
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42902 )
Change subject: mb/google/volteer: set tcc_offset value to 10 ......................................................................
mb/google/volteer: set tcc_offset value to 10
Set tcc_offset value to 10 in devicetree for Thermal Control Circuit (TCC) activation feature.
BUG=None BRANCH=None TEST=Built for volteer platform and verified the MSR value
Change-Id: I6438547e09a3ff3a1c01addfcc01383e89f5b435 Signed-off-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42902 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 0c581a5..300fb7e 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -222,6 +222,8 @@
register "Device4Enable" = "1"
+ register "tcc_offset" = "10" # TCC of 90 + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value |
-
Patrick Georgi (Code Review) -
Sumeet R Pawnikar (Code Review)
-
Tim Wawrzynczak (Code Review)