[M] Change in coreboot[main]: mb/getac/p470/hda_verb: Use macros instead of magic numbers

[Nicholas Chin (Code Review)]

Attention is currently required from: Elyes Haouas.

Nicholas Chin has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84246?usp=email )

Change subject: mb/getac/p470/hda_verb: Use macros instead of magic numbers
......................................................................

Patch Set 1:

(9 comments)

File src/mainboard/getac/p470/hda_verb.c:

PS1: 
How did you determine these? A lot of them do not decode to the same value as the original magic numbers.

https://review.coreboot.org/c/coreboot/+/84246/comment/28e4e19e_b3343c4c?usp... :
PS1, Line 17: AZALIA_PIN_DESC(
            : 		AZALIA_JACK,
            : 		AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_FRONT,
            : 		AZALIA_MIC_IN,
            : 		AZALIA_STEREO_MONO_1_8,
            : 		AZALIA_COLOR_UNKNOWN,
            : 		AZALIA_NO_JACK_PRESENCE_DETECT,
            : 		1, 0
            : 	)
Any configs like `0x411111fn` should be replaced with `AZALIA_PIN_CFG_NC(n)`

https://review.coreboot.org/c/coreboot/+/84246/comment/1742d45b_63ddac62?usp... :
PS1, Line 50: AZALIA_PIN_DESC(
            : 		AZALIA_JACK,
            : 		AZALIA_INTERNAL,
            : 		AZALIA_SPEAKER,
            : 		AZALIA_OTHER_ANALOG,
            : 		AZALIA_COLOR_UNKNOWN,
            : 		AZALIA_NO_JACK_PRESENCE_DETECT,
            : 		1, 0
            : 	)
`AZALIA_PIN_CFG_NC(0)`

https://review.coreboot.org/c/coreboot/+/84246/comment/825eaf91_c11c59f4?usp... :
PS1, Line 108: AZALIA_CD_IN
This doesn't exist?

https://review.coreboot.org/c/coreboot/+/84246/comment/1bdb1658_f5cf595e?usp... :
PS1, Line 105: AZALIA_PIN_DESC(
             : 		AZALIA_JACK,
             : 		AZALIA_INTERNAL,
             : 		AZALIA_CD_IN,
             : 		AZALIA_OTHER_ANALOG,
             : 		AZALIA_COLOR_UNKNOWN,
             : 		AZALIA_NO_JACK_PRESENCE_DETECT,
             : 		1, 0
             : 	)
`AZALIA_PIN_CFG_NC(0)`

https://review.coreboot.org/c/coreboot/+/84246/comment/29e834c6_53f8ad61?usp... :
PS1, Line 119: AZALIA_BEEP
This doesn't exist?

https://review.coreboot.org/c/coreboot/+/84246/comment/a1c035ae_a1b3fed4?usp... :
PS1, Line 116: AZALIA_PIN_DESC(
             : 		AZALIA_INTEGRATED,
             : 		AZALIA_INTERNAL,
             : 		AZALIA_BEEP,
             : 		AZALIA_OTHER_ANALOG,
             : 		AZALIA_COLOR_UNKNOWN,
             : 		AZALIA_NO_JACK_PRESENCE_DETECT,
             : 		1, 0
             : 	)
`AZALIA_PIN_CFG_NC(0)`

https://review.coreboot.org/c/coreboot/+/84246/comment/fde8d00d_fda9bf06?usp... :
PS1, Line 127: AZALIA_PIN_DESC(
             : 		AZALIA_JACK,
             : 		AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_REAR,
             : 		AZALIA_DIGITAL_OUT,
             : 		AZALIA_OTHER_DIGITAL,
             : 		AZALIA_BLACK,
             : 		AZALIA_JACK_PRESENCE_DETECT,
             : 		1, 0
             : 	)
`AZALIA_PIN_CFG_NC(0)`

https://review.coreboot.org/c/coreboot/+/84246/comment/8cd17981_006d60eb?usp... :
PS1, Line 138: AZALIA_PIN_DESC(
             : 		AZALIA_JACK,
             : 		AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_FRONT,
             : 		AZALIA_DIGITAL_IN,
             : 		AZALIA_OTHER_DIGITAL,
             : 		AZALIA_BLACK,
             : 		AZALIA_JACK_PRESENCE_DETECT,
             : 		1, 0
             : 	)
`AZALIA_PIN_CFG_NC(0)`