Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Martin Roth, Marshall Dawson, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56919 )
Change subject: soc/amd/common: Skip psp_verstage on S0i3 resume ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56919/comment/a9fa8da5_9a4a506c PS1, Line 10: : =
https://review.coreboot.org/c/coreboot/+/56919/comment/c9ed48fd_a1b07810 PS1, Line 10: S0i3 psp_verstage
File src/soc/amd/common/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/56919/comment/e0e444cb_1fd4025e PS1, Line 205: Currently, we want to skip running verstage on all S0i3 resumes. This relies : on an assumption that the PSP will be checksumming all of its components.
If verstage must not run on S0i3 resume, then I would expect PSP BL to not load this component at al […]
Yes that is the eventual goal. We decided to introduce this change for 2 reasons: 1) PSP release takes some time. 2) Also PSP team has been waiting on inputs on this bug: b/177064859 to avoid loading PSP verstage on S0i3. The concern is that PSP is loading lots of firmware components from SPI ROM on S0i3 resume
This is an alternative approach until a consensus is reached on the above 2 factors.
https://review.coreboot.org/c/coreboot/+/56919/comment/f83de323_5db2f1c2 PS1, Line 207: svc_get_boot_mode(&bootmode);
I think we are doing this in verstage because it was the shortest path. […]
Preferably not. Please refer to the above comment.