Attention is currently required from: Lance Zhao, Tim Wawrzynczak.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74326 )
Change subject: soc/intel: Introduce ioapic_get_sci_pin()
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/baytrail/acpi.c:
https://review.coreboot.org/c/coreboot/+/74326/comment/678c8302_69d2f63e
PS1, Line 299: current += acpi_create_madt_irqoverride(irqovr, 0, irq, gsi, flags);
In the case !ACPI_HAVE_PCAT_8259, assert irq==gsi since no redirection is desired ?
Newly introduced acpi_create_madt_sci_override() should avoid the redirection now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74326
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I723c207f1dcbba5e6fc0452fe1dbd087fad290ee
Gerrit-Change-Number: 74326
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Comment-Date: Tue, 11 Apr 2023 20:20:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment