Attention is currently required from: Wisley Chen. Hello Wisley Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/62820
to review the following change.
Change subject: soc/intel/common/block/cse: Change logleve prefix to WARNING ......................................................................
soc/intel/common/block/cse: Change logleve prefix to WARNING
In do_send_end_of_post(), it checks whether send eop or not. So, it's better to use "BIOS_WARNING" than "BIOS_ERR"
BUG=b:222038287 BRANCH=firmware-brya-14505.B TEST=build
Signed-off-by: Wisley Chen wisley.chen@quanta.corp-partner.google.com Change-Id: I57a34334007a6a7443302c2f25de3d5c87c85573 --- M src/soc/intel/common/block/cse/cse_eop.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/62820/1
diff --git a/src/soc/intel/common/block/cse/cse_eop.c b/src/soc/intel/common/block/cse/cse_eop.c index bc6d837..1d64ecc 100644 --- a/src/soc/intel/common/block/cse/cse_eop.c +++ b/src/soc/intel/common/block/cse/cse_eop.c @@ -172,7 +172,7 @@ static bool eop_sent = false;
if (eop_sent) { - printk(BIOS_ERR, "EOP already sent\n"); + printk(BIOS_WARNING, "EOP already sent\n"); return; }