Attention is currently required from: Paul Menzel.
Hualin Wei has posted comments on this change by Hualin Wei. ( https://review.coreboot.org/c/coreboot/+/84898?usp=email )
Change subject: mb/google/dedede/var/awasuki: Tune I2C touchpad for freq and TH ......................................................................
Patch Set 10:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84898/comment/8d147552_cc71034a?usp... : PS6, Line 4: hualin wei
Please update your Gerrit settings to also use Wei Hualin. […]
Done
https://review.coreboot.org/c/coreboot/+/84898/comment/e18d10cf_5663f45a?usp... : PS6, Line 7: Modify parameters of touchpad I2C
Maybe: […]
We have made changes to prevent exceeding 72 characters.
https://review.coreboot.org/c/coreboot/+/84898/comment/02a79063_1f70b0b9?usp... : PS6, Line 11: time of high(TH)
Please add a space before the (.
Done
File src/mainboard/google/dedede/variants/awasuki/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84898/comment/356d319b_3f4a7488?usp... : PS6, Line 34: .speed = I2C_SPEED_FAST, : .scl_lcnt = 178, : .scl_hcnt = 92, : .sda_hold = 40,
Which of the four values did you have to edit for the frequency and which for time of high?
We need to use speed, scl_lcnt and scl_hcnt to adjust the frequency, and scl_lcnt and scl_hcnt to adjust the TH. And sda_hold should be greater than 30.