Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51069 )
Change subject: mb/google/guybrush: Add option to toggle GPIO for sign of life ......................................................................
mb/google/guybrush: Add option to toggle GPIO for sign of life
Enabling the GPIO_SIGN_OF_LIFE option will allow for early boot testing.
BUG=b:180721202 TEST=builds
Change-Id: I069623ae76a4e4d1e43a47dd95fdfcece398ebfb Signed-off-by: Mathew King mathewk@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/51069 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/guybrush/Kconfig M src/mainboard/google/guybrush/bootblock.c 2 files changed, 19 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified EricR Lai: Looks good to me, approved
diff --git a/src/mainboard/google/guybrush/Kconfig b/src/mainboard/google/guybrush/Kconfig index bd4848c..46e8a5a 100644 --- a/src/mainboard/google/guybrush/Kconfig +++ b/src/mainboard/google/guybrush/Kconfig @@ -55,4 +55,11 @@ string default "Google_Guybrush"
+config GPIO_SIGN_OF_LIFE + def_bool n + help + Enable toggling GPIO 31 as a sign of life on Guybrush + + TODO: Remove this option when board is booting + endif # BOARD_GOOGLE_BASEBOARD_GUYBRUSH diff --git a/src/mainboard/google/guybrush/bootblock.c b/src/mainboard/google/guybrush/bootblock.c index d7a30b0..5eacd0b 100644 --- a/src/mainboard/google/guybrush/bootblock.c +++ b/src/mainboard/google/guybrush/bootblock.c @@ -2,6 +2,9 @@
#include <bootblock_common.h> #include <baseboard/variants.h> +#include <delay.h> +#include <gpio.h> +#include <soc/gpio.h>
void bootblock_mainboard_early_init(void) { @@ -10,4 +13,13 @@
gpios = variant_bootblock_gpio_table(&num_gpios); program_gpios(gpios, num_gpios); + + if (CONFIG(GPIO_SIGN_OF_LIFE)) { + for (int x = 0; x < 20; x++) { + gpio_set(GPIO_31, 1); + mdelay(10); + gpio_set(GPIO_31, 0); + mdelay(10); + } + } }