Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31832 )
Change subject: mb/gigabyte/ga-h61ma-d3v: Add new mainboard as variant
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31832/1/src/mainboard/gigabyte/ga-h61m-s2pv/...
File src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig:
https://review.coreboot.org/#/c/31832/1/src/mainboard/gigabyte/ga-h61m-s2pv/...
PS1, Line 25: select NORTHBRIDGE_INTEL_SANDYBRIDGE if BOARD_GIGABYTE_GA_H61MA_D3V
: select NORTHBRIDGE_INTEL_IVYBRIDGE if BOARD_GIGABYTE_GA_H61M_S2PV
The selected northbridge in the code should not make much difference except for libgfxinit, which wi […]
Ok, better add a comment here about libgfxinit and why the distinction is made.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31832
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37928de158bb8fbb47fbda5d1ccd4efba7edab26
Gerrit-Change-Number: 31832
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 24 Mar 2019 10:34:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment