Patrick Georgi (pgeorgi@google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10933
-gerrit
commit c2a430634c32d782e338c4918a8ccbda18a29d6c Author: Patrick Georgi pgeorgi@chromium.org Date: Wed Jul 15 18:28:23 2015 +0200
cbfstool: rename checksum to attributes
So far it's still unused, but its purpose will change: It will become an offset to another structure that contains additional file attributes.
This change is compatible because the binary format doesn't change and so far the field was always set to 0, which can serve nicely as 'unused' field.
Change-Id: I2dafb06866713d43a236556f9492641526270837 Signed-off-by: Patrick Georgi pgeorgi@chromium.org --- util/cbfstool/cbfs.h | 2 +- util/cbfstool/cbfs_image.c | 2 +- util/cbfstool/common.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/util/cbfstool/cbfs.h b/util/cbfstool/cbfs.h index 1996b1c..05eabe8 100644 --- a/util/cbfstool/cbfs.h +++ b/util/cbfstool/cbfs.h @@ -74,7 +74,7 @@ struct cbfs_file { /* length of file data */ uint32_t len; uint32_t type; - uint32_t checksum; + uint32_t attributes; /* length of header incl. variable data */ uint32_t offset; char filename[]; diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c index 828d367..47aa5aa 100644 --- a/util/cbfstool/cbfs_image.c +++ b/util/cbfstool/cbfs_image.c @@ -1035,7 +1035,7 @@ int cbfs_create_empty_entry(struct cbfs_file *entry, memcpy(entry->magic, CBFS_FILE_MAGIC, sizeof(entry->magic)); entry->type = htonl(CBFS_COMPONENT_NULL); entry->len = htonl(len); - entry->checksum = 0; // TODO Build a checksum algorithm. + entry->attributes = 0; entry->offset = htonl(cbfs_calculate_file_header_size(name)); memset(entry->filename, 0, ntohl(entry->offset) - sizeof(*entry)); strcpy(entry->filename, name); diff --git a/util/cbfstool/common.c b/util/cbfstool/common.c index fffd096..b95e8bc 100644 --- a/util/cbfstool/common.c +++ b/util/cbfstool/common.c @@ -131,7 +131,7 @@ void cbfs_file_get_header(struct buffer *buf, struct cbfs_file *file) bgets(buf, &file->magic, sizeof(file->magic)); file->len = xdr_be.get32(buf); file->type = xdr_be.get32(buf); - file->checksum = xdr_be.get32(buf); + file->attributes = xdr_be.get32(buf); file->offset = xdr_be.get32(buf); }