[XS] Change in coreboot[main]: mb/sifive/hifive-unleashed: Disable SEPARATE_ROMSTAGE - coreboot-gerrit

16 Apr 2024


      Attention is currently required from: Maximilian Brune, Philipp Hug, ron minnich.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81910?usp=email )
Change subject: mb/sifive/hifive-unleashed: Disable SEPARATE_ROMSTAGE
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81910/comment/3a6507ef_d355e622 :
PS1, Line 18: The coreboot LZ4 decompression code does some misaligned access during
            : decompression
I don't know how deep this rabbit hole goes, but wouldn't it be
better to fix the code? AIUI, unaligned accesses are less efficient
but decompression should be most performant?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/81910?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id165829bfd35be2bce2bbb019c208a304f627add
Gerrit-Change-Number: 81910
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Philipp Hug philipp@hug.cx
Gerrit-Attention: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Attention: ron minnich rminnich@gmail.com
Gerrit-Comment-Date: Tue, 16 Apr 2024 08:57:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment