Attention is currently required from: Ashish Kumar Mishra, Cliff Huang, Dinesh Gehlot, Elyes Haouas, Eran Mitrani, Felix Singer, Jakub Czapiga, Jamie Ryu, Jérémy Compostella, Kapil Porwal, Ravishankar Sarawadi, Saurabh Mishra, Tarun, Wonkyu Kim.
Subrata Banik has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83354?usp=email )
Change subject: soc/intel/ptl: Do initial Panther Lake SoC commit till bootblock
......................................................................
Patch Set 62:
(1 comment)
File src/soc/intel/pantherlake/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/83354/comment/b2fb85a5_793d66a6?usp... :
PS48, Line 72: #define P2SB2_BAR CONFIG_P2SB_2_PCR_BASE_ADDRESS
This name was suggested by Subrata, we had resolved this query earlier to be using "P2SB_2_PCR_BASE_ […]
PCR means private configuration register space which doesn't depict the actual picture that there are two P2SB IP in each die hence, we need two different BARs which is PCR of P2SB. I think P2SB2 is more meaningful than PCR2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83354?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibcfe71eec27cebf04f10ec343a73dd92f1272aca
Gerrit-Change-Number: 83354
Gerrit-PatchSet: 62
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Cliff Huang
cliff.huang@intel.com
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Vikrant L Jadeja
vikrant.l.jadeja@intel.com
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 08 Aug 2024 06:06:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Saurabh Mishra
mishra.saurabh@intel.com
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com