Attention is currently required from: Subrata Banik.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74209 )
Change subject: soc/intel/cmn/block/cse: Implement an API to get ISH version ......................................................................
Patch Set 5:
(3 comments)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/74209/comment/1758c942_b22a0b81 PS4, Line 1216: /* : * This API can only be executed after FSP-M has been initialized. This is because the : * command relies on resources that are not available until CSE DRAM initialization : * command has been sent. : */
Give one space to start with, here is some sample style which u can follow. […]
Ack
https://review.coreboot.org/c/coreboot/+/74209/comment/bf567737_bcd32def PS4, Line 1221: #if ENV_RAMSTAGE
keep everything inside same #if ENV_RAMSTAGE at line 1267
Ack
https://review.coreboot.org/c/coreboot/+/74209/comment/5722f71f_19d0ed20 PS4, Line 1227: sizeof(struct fw_version)
use directly in line #1229
Ack