[L] Change in coreboot[main]: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge)

[Felix Singer (Code Review)]

Attention is currently required from: Paul Menzel, Ronald Claveau.

Felix Singer has posted comments on this change by Ronald Claveau. ( https://review.coreboot.org/c/coreboot/+/83104?usp=email )

Change subject: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge)
......................................................................

Patch Set 12:

(7 comments)

File src/mainboard/dell/xps_8300/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/83104/comment/8ac4b72a_644bad36?usp... :
PS11, Line 1: chip northbridge/intel/sandybridge
>

Done

https://review.coreboot.org/c/coreboot/+/83104/comment/97207727_aa497562?usp... :
PS11, Line 6: 			register "gen1_dec" = "0x003c0a01"
> Move this into the scope of the LPC controller

Done

https://review.coreboot.org/c/coreboot/+/83104/comment/65f9af9a_0aac2e19?usp... :
PS11, Line 8: 			register "sata_interface_speed_support" = "0x3"
            :
> Move these into the scope of the SATA controller

Done

https://review.coreboot.org/c/coreboot/+/83104/comment/3c1b78c6_ecec6cf0?usp... :
PS11, Line 30: # Management Engine Interface 1
> These comments duplicate the alias names. Remove them as well.

Done

https://review.coreboot.org/c/coreboot/+/83104/comment/aa1d92b1_4b63464c?usp... :
PS11, Line 33: off
> Remove all devices which are turned off. They are disabled in the chipset devicetree.

Done

File src/mainboard/dell/xps_8300/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/83104/comment/9edbdd9d_e5197c51?usp... :
PS11, Line 5:
> nit: Remove one blank line

Done

File src/mainboard/dell/xps_8300/early_init.c:

https://review.coreboot.org/c/coreboot/+/83104/comment/deb1b014_97539e07?usp... :
PS11, Line 3:
> nit: Remove one blank line

Done