Attention is currently required from: Kenneth Chan, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60328 )
Change subject: mb/google/guybrush/var/dewatt: disable unused PCIe clock setting
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60328/comment/ac5a0f11_36d7f6b3
PS1, Line 9: Disable unused PCIe GPP_CLK1 and GPP_CLK2 for dewatt.
Just for correctness, or does this fix some problem? The source is the schematics?
https://review.coreboot.org/c/coreboot/+/60328/comment/dcf9fb24_c1b1f3ac
PS1, Line 12: TEST=emerge-guybrush coreboot
How can this be tested?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60328
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If449453bc60ed41e104346429babc06a73acef64
Gerrit-Change-Number: 60328
Gerrit-PatchSet: 1
Gerrit-Owner: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 24 Dec 2021 16:22:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment