Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33954 )
Change subject: mb/google/hatch/variants: Fix nonworking touch pad
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33954/5/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/helios/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/33954/5/src/mainboard/google/hatch/...
PS5, Line 81: CPI_IRQ_EDGE_LOW(GPP_A21_IRQ)"
You will still need this change for helios.
CL:33820 have modify GPP_A21
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33954
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60816a4652fa39ab2a91034b268efe8f84a13e17
Gerrit-Change-Number: 33954
Gerrit-PatchSet: 5
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aamir Bohra
aamir.bohra@intel.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 04 Jul 2019 02:40:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment