Attention is currently required from: Michael Niewöhner, Nicholas Chin.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80452?usp=email )
Change subject: include/device/azalia_device.h: Add enum for misc field
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2:
Looks good in general. 👍
File src/include/device/azalia_device.h:
https://review.coreboot.org/c/coreboot/+/80452/comment/3920ec05_f81945ff :
PS2, Line 117: NO_JACK_PRESENCE_DETECT
nit: Add a comma here
https://review.coreboot.org/c/coreboot/+/80452/comment/5cc3c07c_174ac260 :
PS2, Line 118: }
Missing a semicolon here but otherwise looks good to me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80452?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I70cbfca8541828a1e0c7280887060c04e4c71721
Gerrit-Change-Number: 80452
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Tue, 13 Feb 2024 12:53:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment