Change in coreboot[master]: soc: common: gpio: Define a macro for the gpio offset - coreboot-gerrit

3 Jul 2021


      Attention is currently required from: Ravi kumar, Taniya Das, Ravi Kumar Bokka.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55948 )
Change subject: soc: common: gpio: Define a macro for the gpio offset
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55948/comment/5dfb61a7_222f3242 
PS1, Line 7: soc: common: gpio
...
Ack
I actually don't see this update.  In general, please stick with the '/' format that was suggested instead of using the ':' formwat.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55948
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iefdde8f8331cf1df2e88a2c8915aefb4fa091d65
Gerrit-Change-Number: 55948
Gerrit-PatchSet: 1
Gerrit-Owner: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: Taniya Das tdas@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Shelley Chen shchen@google.com
Gerrit-Attention: Ravi kumar rbokka@codeaurora.org
Gerrit-Attention: Taniya Das tdas@codeaurora.org
Gerrit-Attention: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Fri, 02 Jul 2021 23:39:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen shchen@google.com
Comment-In-Reply-To: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-MessageType: comment