Attention is currently required from: Anjaneya "Reddy" Chagam, Johnny Lin, Christian Walter, Arthur Heymans, Shuming Chu (Shuming), TangYiwei.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68912 )
Change subject: soc/intel/xeon_sp: Don't sort struct device cpus for numa
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68912/comment/70f8bc4f_77b81874
PS3, Line 15: This moves the sorting to of the lapic_ids to the srat table generation
This moves the sorting to of --> This moves the sorting of ?
File src/soc/intel/xeon_sp/util.c:
https://review.coreboot.org/c/coreboot/+/68912/comment/278e9fa6_e67f1491
PS3, Line 161: uint8_t get_cpu_package(const uint32_t apic_id)
Could we add some comments here? Such as what it means by a "package" in this context?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68912
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I372bcea1932d28e9bf712cc712f19a76fe3199b1
Gerrit-Change-Number: 68912
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: TangYiwei
Gerrit-Comment-Date: Mon, 31 Oct 2022 16:24:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment