Attention is currently required from: Felix Singer, Jérémy Compostella, Paul Menzel, جوكر الطويل.
yuchi.chen@intel.com has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83314?usp=email )
Change subject: soc/intel/common: Add CPU and PCIe IDs for Snow Ridge platform
......................................................................
Patch Set 8:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83314/comment/90e09ca1_bd328f10?usp... :
PS1, Line 7: add CPU and PCIe definitions for SNR
Suggestion: […]
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/83314/comment/85571f0e_f0221c31?usp... :
PS3, Line 8:
These IDs are described in the EDS file of Snow Ridge SoC, I've added it in the commit message.
Done
File src/include/cpu/intel/cpu_ids.h:
https://review.coreboot.org/c/coreboot/+/83314/comment/dab2e3a1_eb4b6b58?usp... :
PS1, Line 86: #define CPUID_SNOWRIDGE_A0 0x80660
Yes, I've added it.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83314?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3f5d612765bbe9adffe0b6c7a4151f32b33e88b4
Gerrit-Change-Number: 83314
Gerrit-PatchSet: 8
Gerrit-Owner: yuchi.chen@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: جوكر الطويل
goker.g700@gmail.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: جوكر الطويل
goker.g700@gmail.com
Gerrit-Comment-Date: Tue, 06 Aug 2024 05:05:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: yuchi.chen@intel.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org