Attention is currently required from: Anil Kumar K, Bora Guvendik, Elyes Haouas, Jamie Ryu, Jérémy Compostella, Kapil Porwal, Pranava Y N, Ravishankar Sarawadi, Saurabh Mishra, Subrata Banik, Wonkyu Kim.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83789?usp=email )
Change subject: soc/intel/ptl: Add GPIOs for Panther Lake SOC
......................................................................
Patch Set 45:
(2 comments)
File src/soc/intel/pantherlake/gpio.c:
https://review.coreboot.org/c/coreboot/+/83789/comment/44e3db8f_c2c05a7a?usp... :
PS17, Line 54: .port = PID_GPIOCOM0,
For constructing PCR addresses to access the register, 8-bit port id is used. […]
in MTL, we have:
IOM_AUX_ORI_BIAS_CTRL_PUP[0] 0x1070
7:0 RW 0x0 GROUP_ID Group ID in PCH GPIO
10:8 RW 0x0 BIT_NUM Data bit Position in PCH GPIO
23:16 RW 0x0 VW_INDEX VW Index in PCH GPIO
https://review.coreboot.org/c/coreboot/+/83789/comment/d3a28450_d1ddae5d?usp... :
PS17, Line 73: .num_groups = ARRAY_SIZE(ptl_community0_groups),
Subrata, Same as cpu_port. […]
Yes, only cpu_port needs to be changed. vw_index and vw_bit are still the same, just also shift left 8-bit because of the port id in the bias registers. I've checked with our team and this comes from the internal GPIO HAS document and this info is not provided in EDS. In fact, I think the current assignment based on community needs to be revisited. IMO, the assignment should be per group.
PTL VW index bit position
com0:
GPP_C_00: 10h 0 <- base is 0x10 for the community
...
GPP_C_07: 10h 7
GPP_C_08: 11h 0
...
GPP_C_23: 12h 7
com1:
GPP_F_00: 10h 0 <- base is 0x10 for the community
...
GPP_F_23: 12h 7
GPP_E_00: 13h 0
...
GPP_E_22: 15h 6
com3:
GPP_A_00: 10h 0 <- base is 0x10 for the community
...
GPP_A_17: 12h 1
GPP_H_00: 13h 0 <- previous position is 1, but start from 0
...
GPP_H_24: 16h 0
com5:
GPP_B_00: 10h 3 <- base is still 0x10, bit position NOT starting from 0
...
GPP_B_25: 13h 1
GPP_D_00: 14h 0 <- previous position is 1, skip to start from 0
...
GPP_D_25: 17h 1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83789?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iae1bc072841214efaec7a10719dbc742f2da795b
Gerrit-Change-Number: 83789
Gerrit-PatchSet: 45
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Vikrant L Jadeja
vikrant.l.jadeja@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 16 Aug 2024 17:14:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com