[M] Change in coreboot[main]: mb/google/nissa/var/gothrax: Add probe and GPIO config for HDMI and ...

[Kapil Porwal (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Nick Vaccaro, Subrata Banik, Yunlong Jia.

Kapil Porwal has posted comments on this change by Yunlong Jia. ( https://review.coreboot.org/c/coreboot/+/85512?usp=email )

Change subject: mb/google/nissa/var/gothrax: Add probe and GPIO config for HDMI and  touchpanel
......................................................................

Patch Set 5: Code-Review+2

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85512/comment/454383f6_a742d904?usp... :
PS5, Line 10: We cannot add a dedicated DB_HDMI field item, so reuse DB_A_HDMI_LTE
            :  (old name:DB_A) as the HDMI switch.
            : We cannot modify the TOUCH_PANEL field item according to the screen
            :  model.
            : Type-C and HDMI use the same interface in hardware，
            :  so turn off the Type-C setting when using HDMI,
            : And use TOUCH_PANEL_I2C_GENERIC to open another screen model.
List of changes:
1. Reuse DB_A (now DB_A_HDMI_LTE) as the HDMI switch.

2. Turn off the Type-C port C1 when using HDMI because both of them use the same interface in hardware.

3. Use TOUCH_PANEL_I2C_GENERIC (formerly TOUCH_PANEL_DISABLE) to support other screen models as we cannot have different fields to support individual touch screen models.

https://review.coreboot.org/c/coreboot/+/85512/comment/821e0aef_3ed1c5cf?usp... :
PS5, Line 18:     field DB_USB 0 1
            :         option DB_NONE          0
            :         option DB_C_A           1
            :         option DB_C_A_LTE       2
            :         option DB_A_HDMI_LTE    3
            : 
            :     field TOUCH_PANEL 9
            :         option TOUCH_PANEL_I2C_HID       0
            :         option TOUCH_PANEL_I2C_GENERIC      1
remove

File src/mainboard/google/brya/variants/gothrax/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/85512/comment/79bcb9ea_9cd8ea94?usp... :
PS5, Line 226: 300
This value is very high and will impact s0ix suspend/resume timings.

Could you please track it as a bug?