Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56630 )
Change subject: mb/google/brya/var/kano: Generate SPD ID for supported parts ......................................................................
mb/google/brya/var/kano: Generate SPD ID for supported parts
Add supported memory parts in mem_parts_used.txt, and generate SPD id for these parts.
MT53E512M32D1NP-046 WT:B MT53E1G32D2NP-046 WT:B H54G46CYRBX267 H54G56CYRBX247 K4U6E3S4AB-MGCL K4UBE3D4AB-MGCL
BUG=b:194766276 b:194686484 b:194765811 TEST=build
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: Iba019c50224be8322865eee7baf81e3a574ff9a4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/56630 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/brya/variants/kano/memory/Makefile.inc M src/mainboard/google/brya/variants/kano/memory/dram_id.generated.txt M src/mainboard/google/brya/variants/kano/memory/mem_parts_used.txt 3 files changed, 15 insertions(+), 13 deletions(-)
Approvals: build bot (Jenkins): Verified Nick Vaccaro: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/kano/memory/Makefile.inc b/src/mainboard/google/brya/variants/kano/memory/Makefile.inc index b0ca222..a81fb3b 100644 --- a/src/mainboard/google/brya/variants/kano/memory/Makefile.inc +++ b/src/mainboard/google/brya/variants/kano/memory/Makefile.inc @@ -1,5 +1,6 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ## This is an auto-generated file. Do not edit!! -## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
-SPD_SOURCES = placeholder.spd.hex +SPD_SOURCES = +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D1NP-046 WT:B, H54G46CYRBX267, K4U6E3S4AB-MGCL +SPD_SOURCES += lp4x-spd-3.hex # ID = 1(0b0001) Parts = MT53E1G32D2NP-046 WT:B, H54G56CYRBX247, K4UBE3D4AB-MGCL diff --git a/src/mainboard/google/brya/variants/kano/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/kano/memory/dram_id.generated.txt index fa24790..ed9007d 100644 --- a/src/mainboard/google/brya/variants/kano/memory/dram_id.generated.txt +++ b/src/mainboard/google/brya/variants/kano/memory/dram_id.generated.txt @@ -1 +1,7 @@ DRAM Part Name ID to assign +MT53E512M32D1NP-046 WT:B 0 (0000) +MT53E1G32D2NP-046 WT:B 1 (0001) +H54G46CYRBX267 0 (0000) +H54G56CYRBX247 1 (0001) +K4U6E3S4AB-MGCL 0 (0000) +K4UBE3D4AB-MGCL 1 (0001) diff --git a/src/mainboard/google/brya/variants/kano/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/kano/memory/mem_parts_used.txt index 9cff262..a188982 100644 --- a/src/mainboard/google/brya/variants/kano/memory/mem_parts_used.txt +++ b/src/mainboard/google/brya/variants/kano/memory/mem_parts_used.txt @@ -1,11 +1,6 @@ -# This is a CSV file containing a list of memory parts used by this variant. -# One part per line with an optional fixed ID in column 2. -# Only include a fixed ID if it is required for legacy reasons! -# Generated IDs are dependent on the order of parts in this file, -# so new parts must always be added at the end of the file! -# -# Generate an updated Makefile.inc and dram_id.generated.txt by running the -# gen_part_id tool from util/spd_tools/lp4x. -# See util/spd_tools/lp4x/README.md for more details and instructions. - -# Part Name +MT53E512M32D1NP-046 WT:B +MT53E1G32D2NP-046 WT:B +H54G46CYRBX267 +H54G56CYRBX247 +K4U6E3S4AB-MGCL +K4UBE3D4AB-MGCL