Attention is currently required from: Michał Żygowski, Subrata Banik, Michał Kopeć.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63493 )
Change subject: soc/intel/alderlake: add chipset devicetree for ADL-S
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Thinking out loud here, does a fsp_params_common.c, and fsp_params_p_n.c, fsp_params_s.c or something like that make sense? To avoid all of these #ifdefs, I suspect there would be even more
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63493
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1dd72465c458b718ecfcb29c2f7e433a63b89807
Gerrit-Change-Number: 63493
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Comment-Date: Fri, 08 Apr 2022 20:06:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment