[S] Change in coreboot[main]: arch/arm/armv{4,7}/Makefile.inc: Add more finegrained ld-ccopts
Attention is currently required from: Arthur Heymans, Martin L Roth.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75031?usp=email )
Change subject: arch/arm/armv{4,7}/Makefile.inc: Add more finegrained ld-ccopts ......................................................................
Patch Set 11:
(3 comments)
Patchset:
PS6:
It seems kinda silly that we separate CFLAGS and CPPFLAGS into two different variables, and then we […]
Seems to have been resolved?
File src/arch/arm/armv4/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/75031/comment/46360d16_2c06f8b5 : PS11, Line 20: -target arm-eabi Generally, I feel like this kind of stuff belongs in xcompile, not in the architecture Makefile. That's what xcompile is meant for, to figure out the right flags for whatever compiler the user has to do what coreboot expects. Target ABI is supposed to be a property of the compiler (and for GCC it usually is), so if clang needs an extra flag to tell it that xcompile should set it.
In fact, there already seems to be a line in xcompile that tries to do something like this: ``` CFLAGS_CLANG="-target ${clang_arch}-${TABI} $CFLAGS_CLANG" ``` Can't we make that work for this?
https://review.coreboot.org/c/coreboot/+/75031/comment/3946635b_677998db : PS11, Line 34: verstage-ld-ccopts += -target arm-eabi nit: this would probably look cleaner if it always came right after the generic-ccopts.
-
Julius Werner (Code Review)