Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40581 )
Change subject: mainboard/clevo/n141cu: Add new mainboard
......................................................................
Patch Set 27:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40581/10/src/mainboard/clevo/cml-u/...
File src/mainboard/clevo/cml-u/ramstage.c:
https://review.coreboot.org/c/coreboot/+/40581/10/src/mainboard/clevo/cml-u/...
PS10, Line 10: cnl_configure_pads(gpio_table, ARRAY_SIZE(gpio_table));
Why do it this early? in theory, we could end up with wrong values set […]
I don't think this is still necessary. I mark this as done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40581
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f83fab64e4cc9036698ca0fdd5edbb677d77eb9
Gerrit-Change-Number: 40581
Gerrit-PatchSet: 27
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 05 May 2020 15:24:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment