Change in coreboot[master]: mb/asus/f2a85-m_pro: Enable GPIO0 on the super-i/o

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Nico Huber (Code Review)

4 Oct 2020 4 Oct '20

6:16 a.m.

Hello Paul Menzel,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/46015

to review the following change.

Change subject: mb/asus/f2a85-m_pro: Enable GPIO0 on the super-i/o ......................................................................

mb/asus/f2a85-m_pro: Enable GPIO0 on the super-i/o

It was enabled by the vendor firmware.

Also drop spurious `io 0x60 = 0x00` setting. It's the default anyway and the resource is kept disabled (it's controlled by the virtual LDN 2e.008).

Change-Id: I351c93033bf2afd824eb6baa8d7625e7a33a295a Signed-off-by: Nico Huber nico.h@gmx.de --- M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb 1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/46015/1

diff --git a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb index 3f9135c..aa21321 100644 --- a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb +++ b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb @@ -61,8 +61,9 @@ irq 0xf7 = 0x00 irq 0xf8 = 0x00 end - device pnp 2e.8 off # WDT1, GPIO0, GPIO1 - io 0x60 = 0x00 + device pnp 2e.008 off # WDT1 + end + device pnp 2e.108 on # GPIO0, GPIO1 irq 0xe0 = 0xff irq 0xe1 = 0xff irq 0xe2 = 0xff

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Paul Menzel (Code Review)

21 Oct 21 Oct

2:58 p.m.

Paul Menzel has uploaded a new patch set (#2) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/46015 )

Change subject: mb/asus/f2a85-m_pro: Enable GPIO0 on the super-i/o ......................................................................

mb/asus/f2a85-m_pro: Enable GPIO0 on the super-i/o

It is enabled by the vendor firmware.

Also drop spurious `io 0x60 = 0x00` setting. It's the default anyway and the resource is kept disabled (it's controlled by the virtual LDN 2e.008).

This fixes the hang in `PCI: 00:14.3 init` when doing `outb(0, DMA1_RESET_REG)`.

Fixes: 2f8192bc ("asus/f2a85m_pro: Fix superio type in devicetree") Change-Id: I351c93033bf2afd824eb6baa8d7625e7a33a295a Signed-off-by: Nico Huber nico.h@gmx.de --- M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb 1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/46015/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I351c93033bf2afd824eb6baa8d7625e7a33a295a Gerrit-Change-Number: 46015 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Denis 'GNUtoo' Carikli GNUtoo@cyberdimension.org Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

27 Oct 27 Oct

3:59 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46015 )

Change subject: mb/asus/f2a85-m_pro: Enable GPIO0 on the super-i/o ......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/46015/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46015/2//COMMIT_MSG@7 PS2, Line 7: super-i/o Super I/O

-- To view, visit https://review.coreboot.org/c/coreboot/+/46015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I351c93033bf2afd824eb6baa8d7625e7a33a295a Gerrit-Change-Number: 46015 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Denis 'GNUtoo' Carikli GNUtoo@cyberdimension.org Gerrit-Comment-Date: Tue, 27 Oct 2020 10:59:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

3:05 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46015 )

Change subject: mb/asus/f2a85-m_pro: Enable GPIO0 on the super-i/o ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46015/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46015/2//COMMIT_MSG@7 PS2, Line 7: super-i/o

...

Super I/O

Technically, that would be `super I/O` wouldn't it?

-- To view, visit https://review.coreboot.org/c/coreboot/+/46015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I351c93033bf2afd824eb6baa8d7625e7a33a295a Gerrit-Change-Number: 46015 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Denis 'GNUtoo' Carikli GNUtoo@cyberdimension.org Gerrit-Comment-Date: Tue, 27 Oct 2020 22:05:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

28 Oct 28 Oct

4:55 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46015 )

Change subject: mb/asus/f2a85-m_pro: Enable GPIO0 on the super-i/o ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46015/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46015/2//COMMIT_MSG@7 PS2, Line 7: super-i/o

...

Technically, that would be `super I/O` wouldn't it?

I don't mind either.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I351c93033bf2afd824eb6baa8d7625e7a33a295a Gerrit-Change-Number: 46015 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Denis 'GNUtoo' Carikli GNUtoo@cyberdimension.org Gerrit-Comment-Date: Wed, 28 Oct 2020 23:55:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Nico Huber (Code Review)

4:55 p.m.

New subject: Change in coreboot[master]: mb/asus/f2a85-m_pro: Enable GPIO0 on the super I/O

Hello build bot (Jenkins), Paul Menzel, Angel Pons, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46015

to look at the new patch set (#3).

Change subject: mb/asus/f2a85-m_pro: Enable GPIO0 on the super I/O ......................................................................

mb/asus/f2a85-m_pro: Enable GPIO0 on the super I/O

It is enabled by the vendor firmware.

Also drop spurious `io 0x60 = 0x00` setting. It's the default anyway and the resource is kept disabled (it's controlled by the virtual LDN 2e.008).

This fixes the hang in `PCI: 00:14.3 init` when doing `outb(0, DMA1_RESET_REG)`.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/46015/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/46015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I351c93033bf2afd824eb6baa8d7625e7a33a295a Gerrit-Change-Number: 46015 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Denis 'GNUtoo' Carikli GNUtoo@cyberdimension.org Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

4:55 p.m.

New subject: Change in coreboot[master]: mb/asus/f2a85-m_pro: Enable GPIO0 on the super I/O

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46015 )

Change subject: mb/asus/f2a85-m_pro: Enable GPIO0 on the super I/O ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46015/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46015/2//COMMIT_MSG@7 PS2, Line 7: super-i/o

...

I don't mind either.

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/46015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I351c93033bf2afd824eb6baa8d7625e7a33a295a Gerrit-Change-Number: 46015 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Denis 'GNUtoo' Carikli GNUtoo@cyberdimension.org Gerrit-Comment-Date: Wed, 28 Oct 2020 23:55:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Nico Huber (Code Review)

5:01 p.m.

New subject: Change in coreboot[master]: mb/asus/f2a85-m_pro: Enable GPIO0 on the super I/O

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46015 )

Change subject: mb/asus/f2a85-m_pro: Enable GPIO0 on the super I/O ......................................................................

mb/asus/f2a85-m_pro: Enable GPIO0 on the super I/O

It is enabled by the vendor firmware.

Also drop spurious `io 0x60 = 0x00` setting. It's the default anyway and the resource is kept disabled (it's controlled by the virtual LDN 2e.008).

This fixes the hang in `PCI: 00:14.3 init` when doing `outb(0, DMA1_RESET_REG)`.

Fixes: 2f8192bc ("asus/f2a85m_pro: Fix superio type in devicetree") Change-Id: I351c93033bf2afd824eb6baa8d7625e7a33a295a Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/46015 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb 1 file changed, 3 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/46015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I351c93033bf2afd824eb6baa8d7625e7a33a295a Gerrit-Change-Number: 46015 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Denis 'GNUtoo' Carikli GNUtoo@cyberdimension.org Gerrit-MessageType: merged

1480

days inactive

1505

days old

coreboot-gerrit@coreboot.org

7 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
Nico Huber (Code Review)
Paul Menzel (Code Review)