KOUAM Ledoux has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43296 )
Change subject: ACPI: Bump STRAT revision to 3 ......................................................................
ACPI: Bump STRAT revision to 3
This adds SRAT processor local x2APIC, GICC, GIC, ITS and Generic Initiator affinity structures.Current revision is 1.Regarding ACPI v6.3 specs, SRAT revision is 3.
Change-Id: I5a32ffe6f0c5e2491eac29d4ec09a6aa55ff3627 Signed-off-by: kouamdo kouamdoux@gmail.com --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/43296/1
diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index 96919c7..6dae0d8 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -544,10 +544,10 @@ return gicc->length; }
-int acpi_create_srat_gen_init_struct_(acpi_srat_gen_init_struc_t *gen, u8 node, u8 cpu) +int acpi_create_srat_gen_init_struct_(acpi_srat_gen_init_struct_t *gen, u8 node, u8 cpu) { gen->type = 5; - gen->length = sizeof(acpi_srat_gen_init_struc_t); + gen->length = sizeof(acpi_srat_gen_init_struct_t); gen->resv1 = 0; /* TODO: Device Handle type: gen->device_hdle_type*/
diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 3dfb238..aa6bfa1 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -199,7 +199,7 @@ } __packed acpi_mcfg_mmconfig_t;
/* SRAT (System Resource Affinity Table) */ -typedef struct { +typedef struct acpi_srat { acpi_header_t header; u32 resv; u64 resv1; @@ -267,7 +267,7 @@ } __packed acpi_srat_its_t;
/*SRAT: Generic Initiator Affinity Structure*/ -typedef struct acpi_srat_gen_init_struc { +typedef struct acpi_srat_gen_init_struct { u8 type; /* Type (5) */ u8 length; /* Length in bytes (32) */ u16 resv1; /* Reserved */ @@ -276,7 +276,7 @@ u32 device_hdle[4]; /* Device Handle of the Generic Initiator */ u32 flags; /* */ u32 resv2; -} __packed acpi_srat_gen_init_struc_t; +} __packed acpi_srat_gen_init_struct_t;
/* SLIT (System Locality Distance Information Table) */ typedef struct acpi_slit { @@ -952,7 +952,7 @@ int acpi_create_srat_lx2apic(acpi_srat_lx2apic_t *lx2apic, u8 node, u8 x2apic); int acpi_create_srat_gicc(acpi_srat_gicc_t *gicc, u8 node, u8 cpu); int acpi_create_srat_its(acpi_srat_its_t *gicc, u8 node, u8 cpu); -int acpi_create_srat_gen_init_struct_(acpi_srat_gen_init_struc_t *gen, u8 node, u8 cpu); +int acpi_create_srat_gen_init_struct_(acpi_srat_gen_init_struct_t *gen, u8 node, u8 cpu); int acpi_create_mcfg_mmconfig(acpi_mcfg_mmconfig_t *mmconfig, u32 base, u16 seg_nr, u8 start, u8 end); unsigned long acpi_create_srat_lapics(unsigned long current);
KOUAM Ledoux has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43296 )
Change subject: ACPI: Bump STRAT revision to 3 ......................................................................
Patch Set 1:
Please , can you have a look ?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43296 )
Change subject: ACPI: Bump STRAT revision to 3 ......................................................................
Patch Set 1:
(1 comment)
This patch adds nothing and don't change the revision
https://review.coreboot.org/c/coreboot/+/43296/1/src/acpi/acpi.c File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/43296/1/src/acpi/acpi.c@1667 PS1, Line 1667: 1 still SRAT revision = 1 :)
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43296 )
Change subject: ACPI: Bump STRAT revision to 3 ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43296/1/src/include/acpi/acpi.h File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/43296/1/src/include/acpi/acpi.h@202 PS1, Line 202: acpi_srat why this is needed ?
https://review.coreboot.org/c/coreboot/+/43296/1/src/include/acpi/acpi.h@270 PS1, Line 270: acpi_srat_gen_init_struct why you changed this?
https://review.coreboot.org/c/coreboot/+/43296/1/src/include/acpi/acpi.h@279 PS1, Line 279: acpi_srat_gen_init_struct_t and this ?
KOUAM Ledoux has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43296 )
Change subject: ACPI: Bump STRAT revision to 3 ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
KOUAM Ledoux (Code Review)