Attention is currently required from: Hsuan-ting Chen.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75330?usp=email )
Change subject: lib: Support localized text of memory_training_desc in ux_locales.c ......................................................................
Patch Set 9:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75330/comment/841bc3ed_29f5025a : PS9, Line 13: The preram_locales file follows the format:
For 1. I haven't find an easy logic to parse your structures, let me know if there's one I am not awared of.
It looks like the only `string.h` function that is used is `strncmp`. With my proposed format, that can stay the same. We just need to have 2 versions of `move_next`, one for `\x00` (used by `search_for_id`) and the other for `\x01` (used by `search_for`).
Your proposal with the type byte is also fine, but not as compact as mine.
For 2.
Only structures that will be modified in runtime (such as elog, nvdata) need a checksum. The whole CBFS is already verified anyway (either with or without CBFS_VERIFICATION), so we can simply trust the content.