Attention is currently required from: Alicja Michalska, Benjamin Doron, David Milosevic, Felix Held, Felix Singer, Lean Sheng Tan.
Angel Pons has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/83979?usp=email )
Change subject: mb/hardkernel/odroid-h4: Add support for ODROID-H4 series ......................................................................
Patch Set 9:
(3 comments)
File src/mainboard/hardkernel/odroid-h4/Kconfig:
https://review.coreboot.org/c/coreboot/+/83979/comment/8fe10d6a_8674e59c?usp... : PS9, Line 10: select FSP_TYPE_IOT
Is this needed? I remember the IoT FSP had some clock and power gating UPDs for PCIe RPs, is that it […]
There's no Client FSP for ADL-N at the time of writing.
https://review.coreboot.org/c/coreboot/+/83979/comment/d065d8d9_6e76438a?usp... : PS9, Line 18: select USE_LEGACY_8254_TIMER
Do you want this in the board config, and as a select? I think it should be the user's/payload's cho […]
I don't remember why it was selected, but I can remove it.
File src/mainboard/hardkernel/odroid-h4/bootblock.c:
https://review.coreboot.org/c/coreboot/+/83979/comment/90e091f9_8e1b9ad5?usp... : PS9, Line 13: ite_reg_write(GPIO_DEV, 0x26, 0xfb); : ite_reg_write(GPIO_DEV, 0x29, 0x01); : ite_reg_write(GPIO_DEV, 0x2c, 0x41); : ite_reg_write(GPIO_DEV, 0x2d, 0x02); : ite_reg_write(GPIO_DEV, 0xbc, 0xc0); : ite_reg_write(GPIO_DEV, 0xbd, 0x03); : ite_reg_write(GPIO_DEV, 0xc1, 0x0a); : ite_reg_write(GPIO_DEV, 0xc8, 0x00); : ite_reg_write(GPIO_DEV, 0xc9, 0x0a); : ite_reg_write(GPIO_DEV, 0xda, 0xb0); : ite_reg_write(GPIO_DEV, 0xdb, 0x44); Not really. This sets up the Super I/O GPIOs, and the values come from vendor firmware. We don't have the datasheet for this Super I/O so I'm not sure what the values mean. I will expand the comment above, though:
Set up Super I/O GPIOs, values come from vendor firmware
-
Angel Pons (Code Review)