Change in ...coreboot[master]: ACPI: Fill asl_compiler_revision field left empty

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31607

Change subject: ACPI: Fill asl_compiler_revision field left empty
......................................................................

ACPI: Fill asl_compiler_revision field left empty

Change-Id: I1075e872e5cb1990bd330b88bb03322ab9338e86
Signed-off-by: Elyes HAOUAS 
---
M src/arch/x86/acpi.c
1 file changed, 15 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/31607/1

diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c
index f4c7d86..f8c0b48 100644
--- a/src/arch/x86/acpi.c
+++ b/src/arch/x86/acpi.c
@@ -217,6 +217,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_madt_t);
    header->revision = get_acpi_table_revision(MADT);

@@ -245,6 +246,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_mcfg_t);
    header->revision = get_acpi_table_revision(MCFG);

@@ -298,6 +300,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_tcpa_t);
    header->revision = get_acpi_table_revision(TCPA);

@@ -356,6 +359,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_tpm2_t);
    header->revision = get_acpi_table_revision(TPM2);

@@ -475,6 +479,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_srat_t);
    header->revision = get_acpi_table_revision(SRAT);

@@ -501,6 +506,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_dmar_t);
    header->revision = get_acpi_table_revision(DMAR);

@@ -634,6 +640,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_slit_t);
    header->revision = get_acpi_table_revision(SLIT);

@@ -658,6 +665,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_hpet_t);
    header->revision = get_acpi_table_revision(HPET);

@@ -691,6 +699,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(struct acpi_vfct);
    header->revision = get_acpi_table_revision(VFCT);

@@ -716,6 +725,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_ivrs_t);
    header->revision = get_acpi_table_revision(IVRS);

@@ -767,6 +777,7 @@
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
+	header->asl_compiler_revision = asl_revision;

/* One debug device defined */
    dbg2->devices_offset = sizeof(acpi_dbg2_header_t);
@@ -886,6 +897,7 @@
    memcpy(header->oem_table_id, oem_table_id, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_rsdt_t);
    header->revision = get_acpi_table_revision(RSDT);

@@ -905,6 +917,7 @@
    memcpy(header->oem_table_id, oem_table_id, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_xsdt_t);
    header->revision = get_acpi_table_revision(XSDT);

@@ -1015,6 +1028,7 @@
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
+	header->asl_compiler_revision = asl_revision;
    header->length += sizeof(acpi_hest_t);
    header->revision = get_acpi_table_revision(HEST);

@@ -1035,6 +1049,7 @@
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
+	header->asl_compiler_revision = asl_revision;
    header->length += sizeof(acpi_bert_t);
    header->revision = get_acpi_table_revision(BERT);

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31607

to look at the new patch set (#2).

Change subject: ACPI: Fill asl_compiler_revision field left empty
......................................................................

ACPI: Fill asl_compiler_revision field left empty

Change-Id: I1075e872e5cb1990bd330b88bb03322ab9338e86
Signed-off-by: Elyes HAOUAS 
---
M src/arch/x86/acpi.c
1 file changed, 15 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/31607/2

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31607 )

Change subject: ACPI: Fill asl_compiler_revision field left empty
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31607/1/src/arch/x86/acpi.c 
File src/arch/x86/acpi.c:

https://review.coreboot.org/#/c/31607/1/src/arch/x86/acpi.c@900 
PS1, Line 900: 	->asl_compiler_revision = asl_revision;
Lost the start of line, should not compile.
header->asl_compiler

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31607 )

Change subject: ACPI: Fill asl_compiler_revision field left empty
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31607/1/src/arch/x86/acpi.c 
File src/arch/x86/acpi.c:

https://review.coreboot.org/#/c/31607/1/src/arch/x86/acpi.c@900 
PS1, Line 900: 	->asl_compiler_revision = asl_revision;
> Lost the start of line, should not compile. […]

right :)
thank you.

done.

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31607 )

Change subject: ACPI: Fill asl_compiler_revision field left empty
......................................................................

Patch Set 2: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31607 )

Change subject: ACPI: Fill asl_compiler_revision field left empty
......................................................................

ACPI: Fill asl_compiler_revision field left empty

Change-Id: I1075e872e5cb1990bd330b88bb03322ab9338e86
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/31607
Tested-by: build bot (Jenkins) 
Reviewed-by: Nico Huber 
---
M src/arch/x86/acpi.c
1 file changed, 15 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved

diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c
index e06c3ad..1872276 100644
--- a/src/arch/x86/acpi.c
+++ b/src/arch/x86/acpi.c
@@ -223,6 +223,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_madt_t);
    header->revision = get_acpi_table_revision(MADT);

@@ -251,6 +252,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_mcfg_t);
    header->revision = get_acpi_table_revision(MCFG);

@@ -304,6 +306,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_tcpa_t);
    header->revision = get_acpi_table_revision(TCPA);

@@ -362,6 +365,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_tpm2_t);
    header->revision = get_acpi_table_revision(TPM2);

@@ -481,6 +485,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_srat_t);
    header->revision = get_acpi_table_revision(SRAT);

@@ -507,6 +512,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_dmar_t);
    header->revision = get_acpi_table_revision(DMAR);

@@ -640,6 +646,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_slit_t);
    header->revision = get_acpi_table_revision(SLIT);

@@ -664,6 +671,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_hpet_t);
    header->revision = get_acpi_table_revision(HPET);

@@ -697,6 +705,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(struct acpi_vfct);
    header->revision = get_acpi_table_revision(VFCT);

@@ -722,6 +731,7 @@
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_ivrs_t);
    header->revision = get_acpi_table_revision(IVRS);

@@ -773,6 +783,7 @@
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
+	header->asl_compiler_revision = asl_revision;

/* One debug device defined */
    dbg2->devices_offset = sizeof(acpi_dbg2_header_t);
@@ -892,6 +903,7 @@
    memcpy(header->oem_table_id, oem_table_id, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_rsdt_t);
    header->revision = get_acpi_table_revision(RSDT);

@@ -911,6 +923,7 @@
    memcpy(header->oem_table_id, oem_table_id, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);

+	header->asl_compiler_revision = asl_revision;
    header->length = sizeof(acpi_xsdt_t);
    header->revision = get_acpi_table_revision(XSDT);

@@ -1021,6 +1034,7 @@
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
+	header->asl_compiler_revision = asl_revision;
    header->length += sizeof(acpi_hest_t);
    header->revision = get_acpi_table_revision(HEST);

@@ -1041,6 +1055,7 @@
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
+	header->asl_compiler_revision = asl_revision;
    header->length += sizeof(acpi_bert_t);
    header->revision = get_acpi_table_revision(BERT);