Attention is currently required from: Tarun Tuli, Subrata Banik, Ravishankar Sarawadi, Paul Menzel, Kapil Porwal, Anil Kumar K, Uday Bhat, Jairaj Arava.
Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72881 )
Change subject: mb/google/rex: Enable audio BT offload
......................................................................
Patch Set 14:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72881/comment/b70dc693_b93b56a6
PS13, Line 9: Enable BT I2S offload feature.
: SSP1 needs to be used for BT offload and program vGPIO.
Please add a blank line between paragraphs or do not wrap lines after a sentence ends.
Ack
https://review.coreboot.org/c/coreboot/+/72881/comment/3801a720_dfd9d5ce
PS13, Line 10: SSP1 needs to be used for BT offload and program vGPIO.
According to the schematics?
Yes . I2S0 and I2S2 lines are being used for speaker adn HP connections on daughter board. So we have enabled BT offload on SSP1
https://review.coreboot.org/c/coreboot/+/72881/comment/59f60835_d5bd40ec
PS13, Line 13: Playback
Play back
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72881
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46e9702add37464122ffc78826ebf8a6c5b5b07c
Gerrit-Change-Number: 72881
Gerrit-PatchSet: 14
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Harsha B R
harsha.b.r@intel.com
Gerrit-Reviewer: Jairaj Arava
jairaj.arava@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Uday Bhat
uday.m.bhat@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-CC: Uday M Bhat
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-Attention: Uday Bhat
uday.m.bhat@intel.com
Gerrit-Attention: Jairaj Arava
jairaj.arava@intel.com
Gerrit-Comment-Date: Tue, 04 Apr 2023 02:17:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment