Attention is currently required from: Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62941 )
Change subject: mb/google/brya/var/taeko: Improve factory process to avoid mess up eMMC and SSD when first boot. ......................................................................
Patch Set 1:
(6 comments)
File src/mainboard/google/brya/variants/taeko/runtimestorage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144317): https://review.coreboot.org/c/coreboot/+/62941/comment/87e00f9a_fe903e41 PS1, Line 15: if(fw_config_probe(FW_CONFIG(BOOT_NVME_MASK, BOOT_NVME_ENABLED)) && trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144317): https://review.coreboot.org/c/coreboot/+/62941/comment/be218b3a_87af9ae1 PS1, Line 15: if(fw_config_probe(FW_CONFIG(BOOT_NVME_MASK, BOOT_NVME_ENABLED)) && space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144317): https://review.coreboot.org/c/coreboot/+/62941/comment/47e74195_a49ffa1f PS1, Line 16: fw_config_probe(FW_CONFIG(BOOT_EMMC_MASK, BOOT_EMMC_ENABLED))){ space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144317): https://review.coreboot.org/c/coreboot/+/62941/comment/820797a0_f3d3d31b PS1, Line 23: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144317): https://review.coreboot.org/c/coreboot/+/62941/comment/48e7508c_110776a6 PS1, Line 24: if(!gpio_get(GPP_F19)){ space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144317): https://review.coreboot.org/c/coreboot/+/62941/comment/50d52886_24a5ebb0 PS1, Line 24: if(!gpio_get(GPP_F19)){ space required before the open parenthesis '('