Attention is currently required from: Keith Hui, Patrick Rudolph.
Fabian Groffen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77046?usp=email )
Change subject: mb/gigabyte/ga-h77m-d3h: Add Sandy/Ivy Bridge board GA-H77M-D3H
......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS5:
I've cleaned the gpio structs from default values, and verified that gpio25 GPIO_MODE_GPIO works
File src/mainboard/gigabyte/ga-h77m-d3h/gpio.c:
https://review.coreboot.org/c/coreboot/+/77046/comment/c2062eac_82c79cec :
PS3, Line 30: GPIO_MODE_NATIVE
Should be GPIO_MODE_GPIO as DRAM_RESET_GATE_GPIO is 25.
Done
https://review.coreboot.org/c/coreboot/+/77046/comment/d4e6a4f8_fbe705f0 :
PS3, Line 40: GPIO_DIR_OUTPUT
please clean the structs. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77046?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icb3e74326a0a7aaf770d1917a2a0931feadd7eab
Gerrit-Change-Number: 77046
Gerrit-PatchSet: 5
Gerrit-Owner: Fabian Groffen
grobian@gentoo.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Keith Hui
buurin@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Comment-Date: Mon, 30 Oct 2023 18:30:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment