Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jincheng Li, Kapil Porwal, Ronak Kanabar, Tarun.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80693?usp=email )
Change subject: drivers/mrc_cache: Deselect MRC_CACHE_USING_MRC_VERSION by default
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
This is violation of the spec. As per feedback from Intel FSP team. EDK2 binding is the correct way to enable this feature. Looks like on your target FSP platform, this feature is not present hence, you are trying to w/a in upstream code.
Please get this fix at FSP. MRC cache using MRC version is minimum expectation from FSP, why there should be an expectation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80693?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I84fdcfbf3c833a7ccb259a1a1d4be0bcfe291dc3
Gerrit-Change-Number: 80693
Gerrit-PatchSet: 1
Gerrit-Owner: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Thu, 22 Feb 2024 05:36:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment