Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33847
Change subject: lib/gnat: Use ADAFLAGS instead of CFLAGS ......................................................................
lib/gnat: Use ADAFLAGS instead of CFLAGS
Commit 6d7564cdfe (Move -Wlogical-op into xcompile) introduced GCC_ADAFLAGS_<arch> but forgot to use them for libgnat. Fix that.
Change-Id: Ia9079f01bb3c2a08296a3d3cc32fdf4ae5bb60c7 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/lib/gnat/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/33847/1
diff --git a/src/lib/gnat/Makefile.inc b/src/lib/gnat/Makefile.inc index 3f22c0e..c8886ec 100644 --- a/src/lib/gnat/Makefile.inc +++ b/src/lib/gnat/Makefile.inc @@ -24,7 +24,7 @@ -gnatg \ -gnatpg \ -I$$(src)/lib/gnat/ \ - $$(GCC_CFLAGS_$(1)) \ + $$(GCC_ADAFLAGS_$(1)) \
libgnat-$(1)-y += a-unccon.ads libgnat-$(1)-y += ada.ads
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33847 )
Change subject: lib/gnat: Use ADAFLAGS instead of CFLAGS ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33847 )
Change subject: lib/gnat: Use ADAFLAGS instead of CFLAGS ......................................................................
Patch Set 1: Code-Review+2
Tested, working.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33847 )
Change subject: lib/gnat: Use ADAFLAGS instead of CFLAGS ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33847 )
Change subject: lib/gnat: Use ADAFLAGS instead of CFLAGS ......................................................................
lib/gnat: Use ADAFLAGS instead of CFLAGS
Commit 6d7564cdfe (Move -Wlogical-op into xcompile) introduced GCC_ADAFLAGS_<arch> but forgot to use them for libgnat. Fix that.
Change-Id: Ia9079f01bb3c2a08296a3d3cc32fdf4ae5bb60c7 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/33847 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/lib/gnat/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/lib/gnat/Makefile.inc b/src/lib/gnat/Makefile.inc index 3f22c0e..c8886ec 100644 --- a/src/lib/gnat/Makefile.inc +++ b/src/lib/gnat/Makefile.inc @@ -24,7 +24,7 @@ -gnatg \ -gnatpg \ -I$$(src)/lib/gnat/ \ - $$(GCC_CFLAGS_$(1)) \ + $$(GCC_ADAFLAGS_$(1)) \
libgnat-$(1)-y += a-unccon.ads libgnat-$(1)-y += ada.ads
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)