HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46080 )
Change subject: mb/hp: Convert to ASL 2.0 syntax ......................................................................
mb/hp: Convert to ASL 2.0 syntax
Change-Id: Id48df4fa0f8e5486636292ad11b8a86e71db4b17 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/hp/pavilion_m6_1035dx/acpi/gpe.asl 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/46080/1
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/acpi/gpe.asl b/src/mainboard/hp/pavilion_m6_1035dx/acpi/gpe.asl index 1e15d7a..e296ff9 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/acpi/gpe.asl +++ b/src/mainboard/hp/pavilion_m6_1035dx/acpi/gpe.asl @@ -15,7 +15,7 @@
/* USB controller PME# */ Method(_L0B) { - Store("USB PME", Debug) + Debug = "USB PME" /* Notify devices of wake event */ Notify(_SB.PCI0.UOH1, 0x02) Notify(_SB.PCI0.UOH2, 0x02) @@ -38,16 +38,16 @@
/* Lid switch opened or closed */ Method(_L16) { - Store("Lid status changed", Debug) + Debug = "Lid status changed" /* Flip trigger polarity */ - Not(LPOL, LPOL) + LPOL = ~LPOL /* Notify lid object of status change */ Notify(_SB.LID, 0x80) }
/* GPIO0 or GEvent8 event */ Method(_L18) { - Store("PCI bridge wake event", Debug) + Debug = "PCI bridge wake event" /* Notify PCI bridges of wake event */ Notify(_SB.PCI0.PBR4, 0x02) Notify(_SB.PCI0.PBR5, 0x02)
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46080
to look at the new patch set (#3).
Change subject: mb/hp: Convert to ASL 2.0 syntax ......................................................................
mb/hp: Convert to ASL 2.0 syntax
Generated build/dsdt.dsl files are same.
Change-Id: Id48df4fa0f8e5486636292ad11b8a86e71db4b17 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/hp/pavilion_m6_1035dx/acpi/gpe.asl 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/46080/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46080
to look at the new patch set (#4).
Change subject: mb/hp/pavilion_m6_1035dx: Convert to ASL 2.0 syntax ......................................................................
mb/hp/pavilion_m6_1035dx: Convert to ASL 2.0 syntax
Change-Id: Id48df4fa0f8e5486636292ad11b8a86e71db4b17 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/hp/pavilion_m6_1035dx/acpi/gpe.asl M src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl M src/mainboard/hp/pavilion_m6_1035dx/acpi/sleep.asl 3 files changed, 15 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/46080/4
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46080
to look at the new patch set (#5).
Change subject: mb/hp/pavilion_m6_1035dx: Convert to ASL 2.0 syntax ......................................................................
mb/hp/pavilion_m6_1035dx: Convert to ASL 2.0 syntax
Generated 'Build/dsdt.dsl' are identical.
Change-Id: Id48df4fa0f8e5486636292ad11b8a86e71db4b17 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/hp/pavilion_m6_1035dx/acpi/gpe.asl M src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl M src/mainboard/hp/pavilion_m6_1035dx/acpi/sleep.asl 3 files changed, 15 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/46080/5
Attention is currently required from: HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46080 )
Change subject: mb/hp/pavilion_m6_1035dx: Convert to ASL 2.0 syntax ......................................................................
Patch Set 6: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46080 )
Change subject: mb/hp/pavilion_m6_1035dx: Convert to ASL 2.0 syntax ......................................................................
mb/hp/pavilion_m6_1035dx: Convert to ASL 2.0 syntax
Generated 'Build/dsdt.dsl' are identical.
Change-Id: Id48df4fa0f8e5486636292ad11b8a86e71db4b17 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/46080 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/hp/pavilion_m6_1035dx/acpi/gpe.asl M src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl M src/mainboard/hp/pavilion_m6_1035dx/acpi/sleep.asl 3 files changed, 15 insertions(+), 15 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/acpi/gpe.asl b/src/mainboard/hp/pavilion_m6_1035dx/acpi/gpe.asl index 1e15d7a..e296ff9 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/acpi/gpe.asl +++ b/src/mainboard/hp/pavilion_m6_1035dx/acpi/gpe.asl @@ -15,7 +15,7 @@
/* USB controller PME# */ Method(_L0B) { - Store("USB PME", Debug) + Debug = "USB PME" /* Notify devices of wake event */ Notify(_SB.PCI0.UOH1, 0x02) Notify(_SB.PCI0.UOH2, 0x02) @@ -38,16 +38,16 @@
/* Lid switch opened or closed */ Method(_L16) { - Store("Lid status changed", Debug) + Debug = "Lid status changed" /* Flip trigger polarity */ - Not(LPOL, LPOL) + LPOL = ~LPOL /* Notify lid object of status change */ Notify(_SB.LID, 0x80) }
/* GPIO0 or GEvent8 event */ Method(_L18) { - Store("PCI bridge wake event", Debug) + Debug = "PCI bridge wake event" /* Notify PCI bridges of wake event */ Notify(_SB.PCI0.PBR4, 0x02) Notify(_SB.PCI0.PBR5, 0x02) diff --git a/src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl b/src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl index 3aa7a02..6986864 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl +++ b/src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl @@ -56,7 +56,7 @@ */ Method (PNOT) { - Store("Received PNOT call (probably from EC)", Debug) + Debug = "Received PNOT call (probably from EC)" /* TODO: Implement this */ }
@@ -75,7 +75,7 @@ /* Make sure lid trigger polarity is set so that we * trigger an SCI when lid status changes. */ - Not(GE22, LPOL) + LPOL = ~GE22 } }
@@ -95,7 +95,7 @@ /* Toggle wireless */ Method (WLTG) { - Store( Not(GP57), GP57 ) + GP57 = ~GP57 } /* Return lid state */ Method (LIDS) diff --git a/src/mainboard/hp/pavilion_m6_1035dx/acpi/sleep.asl b/src/mainboard/hp/pavilion_m6_1035dx/acpi/sleep.asl index dde9c37..cd714ce 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/acpi/sleep.asl +++ b/src/mainboard/hp/pavilion_m6_1035dx/acpi/sleep.asl @@ -26,20 +26,20 @@ /* DBGO("\n") */
/* Clear sleep SMI status flag and enable sleep SMI trap. */ - /*Store(One, CSSM) - Store(One, SSEN)*/ + /*CSSM = 1 + SSEN = 1*/
/* On older chips, clear PciExpWakeDisEn */ - /*if (LLessEqual(_SB.SBRI, 0x13)) { - * Store(0,_SB.PWDE) + /*if (_SB.SBRI <= 0x13) { + * _SB.PWDE = 0 *} */
/* Clear wake status structure. */ - Store(0, Index(WKST,0)) - Store(0, Index(WKST,1)) + WKST [0] = 0 + WKST [1] = 0
- Store (0x07, UPWS) + UPWS = 0x07 } /* End Method(_PTS) */
/* @@ -64,7 +64,7 @@ /* DBGO(" to S0\n") */
/* Re-enable HPET */ - Store(1,USBS) + USBS = 1
Return(WKST) } /* End Method(_WAK) */
-
HAOUAS Elyes (Code Review) -
Michael Niewöhner (Code Review)