Attention is currently required from: Martin L Roth, Jason Nien, Jon Murphy, Martin Roth.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72769 )
Change subject: mb/google/skyrim: Disable unused SPI ROM types ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/skyrim/Kconfig:
https://review.coreboot.org/c/coreboot/+/72769/comment/e235fdcd_073cdf26 PS3, Line 206: # Gigadevice is used on Whiterun as an alternative to Winbond : config SPI_FLASH_GIGADEVICE : default y : : # XMC chips used on Markarth as an alternative to Winbond : # These chips identify as ST Micro (Manufacturer ID: 0x20) : config SPI_FLASH_STMICRO : default y
While it's possible, my personal preference is that the Kconfig. […]
`skyrim/Kconfig.name` is already being used for device-specific values. For example:
``` config BOARD_GOOGLE_WINTERHOLD bool "-> Winterhold" select BOARD_GOOGLE_BASEBOARD_SKYRIM select SOC_AMD_COMMON_BLOCK_ACPI_DPTC select FEATURE_DYNAMIC_DPTC
config BOARD_GOOGLE_FROSTFLOW bool "-> Frostflow" select BOARD_GOOGLE_BASEBOARD_SKYRIM select DRIVERS_GENESYSLOGIC_GL9755 select FEATURE_TABLET_MODE_DPTC select SOC_AMD_COMMON_BLOCK_ACPI_DPTC ```
I agree that it would be good to have a consensus on this, and cleanup whichever file we settle on.