Change in coreboot[master]: mb/google/octopus/variants/fleex: Only do LTE power off for LTE sku
EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45687 )
Change subject: mb/google/octopus/variants/fleex: Only do LTE power off for LTE sku ......................................................................
mb/google/octopus/variants/fleex: Only do LTE power off for LTE sku
Only do LTE power off for LTE sku in order to save extra 130ms delay for power off.
BUG=b:168075958 BRANCH=octopus TEST=build image and verify on the DUT with LTE DB.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: If983185ff2f09fb1b2553c6ff1a1473d3254de4b --- M src/mainboard/google/octopus/variants/fleex/variant.c 1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/45687/1
diff --git a/src/mainboard/google/octopus/variants/fleex/variant.c b/src/mainboard/google/octopus/variants/fleex/variant.c index 1b0784c..92e6c4c 100644 --- a/src/mainboard/google/octopus/variants/fleex/variant.c +++ b/src/mainboard/google/octopus/variants/fleex/variant.c @@ -2,27 +2,29 @@
#include <acpi/acpi.h> #include <baseboard/variants.h> -#include <delay.h> #include <ec/google/chromeec/ec.h> -#include <gpio.h> #include <sar.h>
+static bool is_lte_sku() +{ + return (google_chromeec_get_board_sku() == 4); +} + void variant_smi_sleep(u8 slp_typ) { /* Currently use cases here all target to S5 therefore we do early return * here for saving one transaction to the EC for getting SKU ID. */ if (slp_typ != ACPI_S5) return; - - power_off_lte_module(); + if (is_lte_sku()) + power_off_lte_module(); }
const char *get_wifi_sar_cbfs_filename(void) { const char *filename = NULL; - uint32_t sku_id = google_chromeec_get_board_sku();
- if (sku_id != 4) + if (!is_lte_sku()) filename = "wifi_sar-fleex.hex";
return filename;
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45687 )
Change subject: mb/google/octopus/variants/fleex: Only do LTE power off for LTE sku ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45687/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/fleex/variant.c:
https://review.coreboot.org/c/coreboot/+/45687/1/src/mainboard/google/octopu... PS1, Line 8: static bool is_lte_sku() Bad function definition - bool is_lte_sku() should probably be bool is_lte_sku(void)
EricR Lai has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/45687 )
Change subject: mb/google/octopus/variants/fleex: Only do LTE power off for LTE sku ......................................................................
mb/google/octopus/variants/fleex: Only do LTE power off for LTE sku
Only do LTE power off for LTE sku in order to save extra 130ms delay for power off.
BUG=b:168075958 BRANCH=octopus TEST=build image and verify on the DUT with LTE DB.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: If983185ff2f09fb1b2553c6ff1a1473d3254de4b --- M src/mainboard/google/octopus/variants/fleex/variant.c 1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/45687/2
Hello build bot (Jenkins), Marco Chen, Marco Chen, Karthikeyan Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45687
to look at the new patch set (#3).
Change subject: mb/google/octopus/variants/fleex: Only do LTE power off for LTE sku ......................................................................
mb/google/octopus/variants/fleex: Only do LTE power off for LTE sku
Only do LTE power off for LTE sku in order to save extra 130ms delay for non-LTE sku.
BUG=b:168075958 BRANCH=octopus TEST=build image and verify on the DUT with LTE DB.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: If983185ff2f09fb1b2553c6ff1a1473d3254de4b --- M src/mainboard/google/octopus/variants/fleex/variant.c 1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/45687/3
Hello build bot (Jenkins), Marco Chen, Marco Chen, Karthikeyan Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45687
to look at the new patch set (#4).
Change subject: mb/google/octopus/variants/fleex: Only do LTE power off for LTE sku ......................................................................
mb/google/octopus/variants/fleex: Only do LTE power off for LTE sku
Only do LTE power off for LTE sku in order to save extra 130ms delay for non-LTE sku.
BUG=b:168075958 BRANCH=octopus TEST=build image and verify on the DUT with LTE DB.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: If983185ff2f09fb1b2553c6ff1a1473d3254de4b --- M src/mainboard/google/octopus/variants/fleex/variant.c 1 file changed, 10 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/45687/4
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45687 )
Change subject: mb/google/octopus/variants/fleex: Only do LTE power off for LTE sku ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45687 )
Change subject: mb/google/octopus/variants/fleex: Only do LTE power off for LTE sku ......................................................................
mb/google/octopus/variants/fleex: Only do LTE power off for LTE sku
Only do LTE power off for LTE sku in order to save extra 130ms delay for non-LTE sku.
BUG=b:168075958 BRANCH=octopus TEST=build image and verify on the DUT with LTE DB.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: If983185ff2f09fb1b2553c6ff1a1473d3254de4b Reviewed-on: https://review.coreboot.org/c/coreboot/+/45687 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marco Chen marcochen@google.com --- M src/mainboard/google/octopus/variants/fleex/variant.c 1 file changed, 10 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Marco Chen: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/fleex/variant.c b/src/mainboard/google/octopus/variants/fleex/variant.c index 1b0784c..f1ec818 100644 --- a/src/mainboard/google/octopus/variants/fleex/variant.c +++ b/src/mainboard/google/octopus/variants/fleex/variant.c @@ -2,27 +2,31 @@
#include <acpi/acpi.h> #include <baseboard/variants.h> -#include <delay.h> #include <ec/google/chromeec/ec.h> -#include <gpio.h> #include <sar.h>
+#define LTE_SKU 4 + +static bool is_lte_sku(void) +{ + return (google_chromeec_get_board_sku() == LTE_SKU); +} + void variant_smi_sleep(u8 slp_typ) { /* Currently use cases here all target to S5 therefore we do early return * here for saving one transaction to the EC for getting SKU ID. */ if (slp_typ != ACPI_S5) return; - - power_off_lte_module(); + if (is_lte_sku()) + power_off_lte_module(); }
const char *get_wifi_sar_cbfs_filename(void) { const char *filename = NULL; - uint32_t sku_id = google_chromeec_get_board_sku();
- if (sku_id != 4) + if (!is_lte_sku()) filename = "wifi_sar-fleex.hex";
return filename;
-
build bot (Jenkins) (Code Review) -
EricR Lai (Code Review)
-
Marco Chen (Code Review)
-
Patrick Georgi (Code Review)