Attention is currently required from: David Wu, Karthik Ramasubramanian, Ren Kuo, Shelley Chen, Subrata Banik, Tyler Wang, YH Lin.
Bob Moragues has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/83212?usp=email )
Change subject: mb/google/brox: Create jubilant variant ......................................................................
Patch Set 23:
(4 comments)
File src/mainboard/google/brox/Kconfig:
https://review.coreboot.org/c/coreboot/+/83212/comment/109054d9_01001ace?usp... : PS17, Line 86: : if BOARD_GOOGLE_BROX_COMMON
put this at the end of line 85 (like lines 83)
OK. Doing that causes problems. Leaving as is....
File src/mainboard/google/brox/variants/jubilant/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83212/comment/27a3dc59_d77eaa44?usp... : PS16, Line 11: 11 12
Move this after ISH to be bits 14 15
Done
https://review.coreboot.org/c/coreboot/+/83212/comment/0572d4fc_c6a7cd19?usp... : PS16, Line 15: 17 18
This should probably match the FP field in config. […]
Done
https://review.coreboot.org/c/coreboot/+/83212/comment/a0e181f3_c70296cd?usp... : PS16, Line 1: fw_config : field STORAGE 2 3 : option STORAGE_UNKNOWN 0 : option STORAGE_UFS 1 : option STORAGE_NVME 2 : end : field WIFI_BT 4 4 : option WIFI_BT_CNVI 0 : option WIFI_BT_PCIE 1 : end : field DB_USB 11 12 : option DB_1A 0 : option DB_1A_LTE 1 : end : field FPMCU 17 18 : option FPMCU_ABSENT 0 : option FPMCU_NUVOTON 1 : end : end
This is what I came up with: […]
Done