Attention is currently required from: Paul Menzel, Kenneth Chan.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59978 )
Change subject: mb/google/guybrush/var/dewatt: Override EN_SPKR GPIO_70
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/guybrush/variants/dewatt/gpio.c:
https://review.coreboot.org/c/coreboot/+/59978/comment/ae8cfd97_571ccfe1
PS2, Line 7: #include <baseboard/variants.h>
nit: newline here
https://review.coreboot.org/c/coreboot/+/59978/comment/94380726_bfa73995
PS2, Line 12: };
nit: newline here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59978
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf705e12f30ad145449be8d97cb214c56c02ec33
Gerrit-Change-Number: 59978
Gerrit-PatchSet: 4
Gerrit-Owner: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 09 Dec 2021 04:17:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment