Hello Nicolas Boichat,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/46583
to review the following change.
Change subject: HACK: Enable display backlight ......................................................................
HACK: Enable display backlight
Change the polarity so that the backlight is at maximum.
BUG=b:155713214 TEST=boot asurada
Change-Id: I058af933e59be84cca77ea15b668be6efcc6539d --- M src/mainboard/google/asurada/mainboard.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/46583/1
diff --git a/src/mainboard/google/asurada/mainboard.c b/src/mainboard/google/asurada/mainboard.c index 30e98e8..56ecc9e 100644 --- a/src/mainboard/google/asurada/mainboard.c +++ b/src/mainboard/google/asurada/mainboard.c @@ -56,8 +56,8 @@ /* Set up backlight control pins as output pin and power-off by default */ static void configure_panel_backlight(void) { - gpio_output(GPIO(KPROW1), 0); - gpio_output(GPIO(DISP_PWM), 0); + gpio_output(GPIO(KPROW1), 1); + gpio_output(GPIO(DISP_PWM), 1); }
static void power_on_panel(struct panel_description *panel)
Yongqiang Niu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46583 )
Change subject: HACK: Enable display backlight ......................................................................
Patch Set 6:
abandon
fix with patch https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+...
yongqiang niu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46583 )
Change subject: HACK: Enable display backlight ......................................................................
Abandoned