Attention is currently required from: Hung-Te Lin, Rex-BC Chen.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68487 )
Change subject: soc/mediatek/mt8188: Add ddp driver to support eDP output ......................................................................
Patch Set 5:
(8 comments)
File src/soc/mediatek/mt8188/ddp.c:
https://review.coreboot.org/c/coreboot/+/68487/comment/104c6980_5268e4fe PS5, Line 1: `OR MIT`?
Also, I found mt8188's tracker.h is the only mt8188 file having the `GPL-2.0-only` license.
https://review.coreboot.org/c/coreboot/+/68487/comment/f194c7bf_6170b867 PS5, Line 82: write32(®s->size, width << 16 | height); Blank line above.
https://review.coreboot.org/c/coreboot/+/68487/comment/e17c7b98_3f696a97 PS5, Line 90: write32(®s->size, width << 16 | height); Same
https://review.coreboot.org/c/coreboot/+/68487/comment/ad8f92bc_8baa994d PS5, Line 97: = 0 No need to initialize.
https://review.coreboot.org/c/coreboot/+/68487/comment/b5952ad1_45a7e2c5 PS5, Line 98: u32 pixel_clk = width * height * vrefresh; const
https://review.coreboot.org/c/coreboot/+/68487/comment/ec6202be_ef5b797b PS5, Line 131: write32 write32p
File src/soc/mediatek/mt8188/include/soc/ddp.h:
https://review.coreboot.org/c/coreboot/+/68487/comment/304f5ae6_7065baaf PS5, Line 54: static struct mmsys_cfg_regs *const mmsys_cfg = (void *)VDOSYS0_BASE; Blank line above.
https://review.coreboot.org/c/coreboot/+/68487/comment/ef906e07_86eebca9 PS5, Line 167: static struct disp_mutex_regs *const disp_mutex = (void *)DISP_MUTEX_BASE; Blank line above.