Change in coreboot[master]: drivers/intel/gma/opregion.c: Fix uninitialised variable use - coreboot-gerrit

23 Mar 2022


      Attention is currently required from: Arthur Heymans, Patrick Rudolph.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61892 )
Change subject: drivers/intel/gma/opregion.c: Fix uninitialised variable use
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/drivers/intel/gma/opregion.c:
https://review.coreboot.org/c/coreboot/+/61892/comment/e90829e4_3d598545 
PS3, Line 335: 	opregion_size += vbt->hdr_vbt_size;
Seems like this could use a comment to the effect that we're adding space for the extended VBT header even if it's not used, since it's not obvious from the field name
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/61892
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87cff1e0360e23e37201381ed8a6920ee36b2747
Gerrit-Change-Number: 61892
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Wed, 23 Mar 2022 21:21:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment