Attention is currently required from: Nico Huber, Tim Wawrzynczak, Werner Zeh. Hello build bot (Jenkins), Nico Huber, Tim Wawrzynczak, Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49442
to look at the new patch set (#2).
Change subject: mb/siemens/mc_apl1: do UART pad configuration at board-level ......................................................................
mb/siemens/mc_apl1: do UART pad configuration at board-level
UART pad configuration should not be done in common code, because that may cause short circuits, when the user sets a wrong UART index. Thus, add the corresponding pads to the early UART gpio table for the board as a first step. Common UART pad config code then gets dropped in CB:48829.
Also switch to `bootblock_mainboard_early_init` to configure the pads in early bootblock before console initialization, to make the console work as early as possible. The board does not do any other gpio configuration in bootblock, so this should not influence behaviour in a negative way (e.g. breaking overrides).
Change-Id: Iac8a6e386b708ae5c4dbf0677bfe05f1358bf8fd Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/siemens/mc_apl1/bootblock.c M src/mainboard/siemens/mc_apl1/variants/baseboard/gpio.c 2 files changed, 7 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/49442/2