Attention is currently required from: Bao Zheng, Jason Glenesk, Marshall Dawson, Matt DeVillier, Zheng Bao, Martin Roth, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69150 )
Change subject: soc/amd/morgana: Add 32M support
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69150/comment/c6042f91_337ffbe4
PS1, Line 24: If coreboot need to access bottom 16M, which in fact doesn't seem to
'implimented' may be misspelled - perhaps 'implemented'?
Please fix.
https://review.coreboot.org/c/coreboot/+/69150/comment/612dacf0_77c669df
PS1, Line 27: The bit 15 of soft fuse decides which (top or bottom) 16M is mapped to
should this be bit 14?
File src/soc/amd/morgana/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/69150/comment/cd235266_0d528560
PS1, Line 118: PSP_SOFTFUSE_BITS += 15
should this be bit 14?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69150
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0b5a75f828033b29c378bed9a939b23d7f19140
Gerrit-Change-Number: 69150
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 07 Nov 2022 19:05:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment